Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Explain Log Rate Spikes: Add tooltip for group columns and adjust copy to reflect groups in ot… #141687

Merged
merged 3 commits into from
Sep 26, 2022
Merged

[ML] Explain Log Rate Spikes: Add tooltip for group columns and adjust copy to reflect groups in ot… #141687

merged 3 commits into from
Sep 26, 2022

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Sep 23, 2022 •
edited by kibanamachine
Loading

Summary

This PR updates the groups table column tooltips to reflect group language and adds a tooltip to the Group column for clarification of column values.

Related meta issue: #141192

image

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner September 23, 2022 17:38
@alvarezmelissa87 alvarezmelissa87 self-assigned this Sep 23, 2022
@alvarezmelissa87 alvarezmelissa87 added :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0 Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.6.0 labels Sep 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra added the bug Fixes for quality problems that affect the customer experience label Sep 26, 2022
walterra
walterra approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 759.4KB 759.8KB +401.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

peteharverson
peteharverson approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

szabosteve
szabosteve approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI text LGTM.

@walterra walterra merged commit 24b7d34 into elastic:main Sep 26, 2022
@kibanamachine kibanamachine mentioned this pull request Sep 26, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 26, 2022
@alvarezmelissa87
[ML] Explain Log Rate Spikes: Add tooltip for group columns and adjus…
ac3a97f 
…t copy to reflect groups in ot… (elastic#141687)

Updates the groups table column tooltips to reflect group language and adds a tooltip to the Group column for clarification of column values.

(cherry picked from commit 24b7d34)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 26, 2022
@kibanamachine @alvarezmelissa87
[ML] Explain Log Rate Spikes: Add tooltip for group columns and adjus…
3109f6d 
…t copy to reflect groups in ot… (#141687) (#141760)

Updates the groups table column tooltips to reflect group language and adds a tooltip to the Group column for clarification of column values.

(cherry picked from commit 24b7d34)

Co-authored-by: Melissa Alvarez <melissa.alvarez@elastic.co>
@alvarezmelissa87 alvarezmelissa87 deleted the ml-aiops-badge-copy branch October 3, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

@szabosteve szabosteve szabosteve approved these changes

@lcawl lcawl Awaiting requested review from lcawl

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
bug Fixes for quality problems that affect the customer experience Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alvarezmelissa87 @elasticmachine @kibana-ci @kibanamachine @walterra @peteharverson @szabosteve